From: Jesper Juhl Date: Mon, 24 Jan 2011 20:14:33 +0000 (+0100) Subject: PCI: Avoid potential NULL pointer dereference in pci_scan_bridge X-Git-Tag: v2.6.39-rc1~416^2~13 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7c867c8899e873652ef98a890d2e647c092bec25;p=pandora-kernel.git PCI: Avoid potential NULL pointer dereference in pci_scan_bridge pci_add_new_bus() calls pci_alloc_child_bus() which calls pci_alloc_bus() that allocates memory dynamically with kzalloc(). The return value of kzalloc() is the pointer that's eventually returned from pci_add_new_bus(), so since kzalloc() can fail and return NULL so can pci_add_new_bus(). Thus we may end up dereferencing a NULL pointer in drivers/pci/probe.c::pci_scan_bridge(). Seems to me we should test for this and bail out if it happens rather than crashing. Also removed some trailing whitespace that bugged me while looking at this. Signed-off-by: Jesper Juhl Signed-off-by: Jesse Barnes --- Reading git-diff-tree failed