From: Pavel Emelyanov Date: Wed, 26 Mar 2008 09:27:09 +0000 (-0700) Subject: [ICMP]: Dst entry leak in icmp_send host re-lookup code (v2). X-Git-Tag: v2.6.25-rc8~77^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7c0ecc4c4f8fd90988aab8a95297b9c0038b6160;p=pandora-kernel.git [ICMP]: Dst entry leak in icmp_send host re-lookup code (v2). Commit 8b7817f3a959ed99d7443afc12f78a7e1fcc2063 ([IPSEC]: Add ICMP host relookup support) introduced some dst leaks on error paths: the rt pointer can be forgotten to be put. Fix it bu going to a proper label. Found after net namespace's lo refused to unregister :) Many thanks to Den for valuable help during debugging. Herbert pointed out, that xfrm_lookup() will put the rtable in case of error itself, so the first goto fix is redundant. Signed-off-by: Pavel Emelyanov Signed-off-by: Denis V. Lunev Signed-off-by: David S. Miller --- Reading git-diff-tree failed