From: David Jeffery Date: Wed, 11 Apr 2012 16:14:25 +0000 (-0400) Subject: [SCSI] st: fix memory leak with >1MB tape I/O X-Git-Tag: v3.5-rc1~172^2~63 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7c018a901c3fef2af9d713ba849e8e52eb82dde1;p=pandora-kernel.git [SCSI] st: fix memory leak with >1MB tape I/O There is a memory leak in the st driver when sending large enough reads or writes using st's direct I/O path. As part of mapping the application's memory, a buffer to hold page pointers is allocated and the count of mapped pages is stored in field do_dio. A non-zero do_dio marks that direct I/O is in use. But do_dio is only 1 byte in size. Mapping 256 4k pages overflows do_dio and causes it to be set to 0, like direct I/O option was not used. When the I/O completes, the buffer to hold the page pointers is not freed, and the page counts of the mapped pages are not reduced. Every I/O of this size then leaks memory. The size of do_dio needs to be increased to prevent it wrapping around. Signed-off-by: David Jeffery Acked-by: Kai Mäkisara Signed-off-by: James Bottomley --- Reading git-diff-tree failed