From: Mauro Carvalho Chehab Date: Mon, 7 Sep 2009 05:22:01 +0000 (-0300) Subject: V4L/DVB (12701): saa7134: ir-kbd-i2c init data needs a persistent object X-Git-Tag: v2.6.32-rc1~679^2~3 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7aedd5ec87686c557d48584d69ad880c11a0984d;p=pandora-kernel.git V4L/DVB (12701): saa7134: ir-kbd-i2c init data needs a persistent object ir-kbd-i2c's ir_probe() function can be called much later (i.e. at ir-kbd-i2c module load), than the lifetime of a struct IR_i2c_init_data allocated off of the stack in cx18_i2c_new_ir() at registration time. Make sure we pass a pointer to a persistent IR_i2c_init_data object at i2c registration time. Thanks to Brian Rogers, Dustin Mitchell, Andy Walls and Jean Delvare to rise this question. Before this patch, if ir-kbd-i2c were probed after SAA7134, trash data were used. Compile tested only, but the patch is identical to em28xx one. So, it should work properly. Signed-off-by: Mauro Carvalho Chehab --- Reading git-diff-tree failed