From: Brian Norris Date: Wed, 26 Feb 2014 02:27:40 +0000 (-0800) Subject: jffs2: fix unbalanced locking X-Git-Tag: omap-for-v4.2/fixes-rc1^2~143^2~39 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7aaea7605c0e19fa7b38d7ac5dcd818942fd17a7;p=pandora-kernel.git jffs2: fix unbalanced locking Li Zefan reported an unbalanced locking issue, found by his internal debugging feature on runtime. The particular case he was looking at doesn't lead to a deadlock, as the structure that this lock is embedded in is freed on error. But we should straighten out the error handling. Because several callers of jffs2_do_read_inode_internal() / jffs2_do_read_inode() already handle the locking/unlocking and inode clearing at their own level, let's just push any unlocks/clearing down to the caller. This consistency is much easier to verify. Reported-by: Li Zefan Cc: David Woodhouse Cc: Artem Bityutskiy Cc: Andrew Morton Signed-off-by: Brian Norris --- Reading git-diff-tree failed