From: Axel Lin Date: Fri, 23 Nov 2012 16:53:22 +0000 (+0800) Subject: regulator: as3711: Fix the logic in as3711_sel_check X-Git-Tag: omap-for-v3.8/fixes-for-merge-window-v4-signed~35^2~25^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a4beda0c6a87af26b7e2144842a0205fa9fd674;p=pandora-kernel.git regulator: as3711: Fix the logic in as3711_sel_check Below equation means the "voltage" is the "smallest" voltage within specific range. ret = DIV_ROUND_UP(min - bottom) / step; voltage = ret * step + bottom; If we do try 1 down when (voltage > max), new voltage is then less than min voltage. Which means the new voltage is not in the requested voltage range. This patch also includes below cleanups: - Use DIV_ROUND_UP - rename variable 'ret' to 'sel' for better readability because as3711_sel_check returns the selector. Signed-off-by: Axel Lin Acked-by: Guennadi Liakhovetski Signed-off-by: Mark Brown --- Reading git-diff-tree failed