From: Catalin Marinas Date: Wed, 15 May 2013 16:49:35 +0000 (+0000) Subject: ACPI / scan: Fix memory leak on acpi_scan_init_hotplug() error path X-Git-Tag: v3.10-rc2~15^2^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a26b53070f0099dfcfc9d499458de861c5c4859;p=pandora-kernel.git ACPI / scan: Fix memory leak on acpi_scan_init_hotplug() error path Following commit 6b772e8f9 (ACPI: Update PNPID match handling for notify), the acpi_scan_init_hotplug() calls acpi_set_pnp_ids() which allocates acpi_hardware_id and copies a few strings (kstrdup). If the devices does not have hardware_id set, the function exits without freeing the previously allocated ids (and kmemleak complains). This patch calls simply changes 'return' on error to a 'goto out' which calls acpi_free_pnp_ids(). Reported-by: Larry Finger Signed-off-by: Catalin Marinas Reviewed-by: Toshi Kani Tested-by: Toshi Kani Signed-off-by: Rafael J. Wysocki --- Reading git-diff-tree failed