From: Lars-Peter Clausen <lars@metafoo.de>
Date: Fri, 13 Jul 2012 12:04:00 +0000 (+0100)
Subject: staging:iio:tsl2x7x: Fix client data inconsistency
X-Git-Tag: v3.6-rc1~100^2~159^2~5
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=79d2a6bd14b117f140817b7d258a54bb5c963473;p=pandora-kernel.git

staging:iio:tsl2x7x: Fix client data inconsistency

In probe the I2C client data is set to the iio_dev struct in probe(), but
assumed to be the tsl2X7X_chip struct in remove(). Fix this by reading the
client data back as iio_dev as well.

The issue has been discovered using the following coccinelle patch:

// <smpl>
@r1@
type T;
T data;
expression dev;
@@
(
i2c_set_clientdata(dev, (void *)data)
|
i2c_set_clientdata(dev, data)
)

@r2@
type r1.T;
T data;
position p;
expression dev;
@@
data = i2c_get_clientdata@p(dev)

@depends on r1@
position p != r2.p;
expression dev;
identifier data;
@@
*data = i2c_get_clientdata@p(dev)
// </smpl>

Cc: Jon Brenner <jbrenner@taosinc.com>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---

Reading git-diff-tree failed