From: Andre Müller Date: Tue, 9 Sep 2014 23:00:22 +0000 (+0200) Subject: x86/efi: Adding efi_printks on memory allocationa and pci.reads X-Git-Tag: fixes-against-v3.18-rc2~16^2^2~4 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=77e21e87acec8c857df4bfbc647ea21d0a87364d;p=pandora-kernel.git x86/efi: Adding efi_printks on memory allocationa and pci.reads All other calls to allocate memory seem to make some noise already, with the exception of two calls (for gop, uga) in the setup_graphics path. The purpose is to be noisy on worrysome errors immediately. commit fb86b2440de0 ("x86/efi: Add better error logging to EFI boot stub") introduces printing false alarms for lots of hardware. Rather than playing Whack a Mole with non-fatal exit conditions, try the other way round. This is per Matt Fleming's suggestion: > Where I think we could improve things > is by adding efi_printk() message in certain error paths. Clearly, not > all error paths need such messages, e.g. the EFI_INVALID_PARAMETER path > you highlighted above, but it makes sense for memory allocation and PCI > read failures. Link: http://article.gmane.org/gmane.linux.kernel.efi/4628 Signed-off-by: Andre Müller Cc: Ulf Winkelvos Signed-off-by: Matt Fleming --- Reading git-diff-tree failed