From: Janusz Sobczak <janusz.sobczak@imgtec.com>
Date: Mon, 9 Aug 2010 11:22:13 +0000 (+0200)
Subject: gpu: pvr: Check OSAllocMem return value.
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=764d6ca6e3b05e4abc03017ebb60f486dda4e3a8;p=sgx.git

gpu: pvr: Check OSAllocMem return value.

Check OSAllocMem() return value instead of checking the pointer returned
as a positional parameter.

This change makes static analysis tool happy.

Signed-off-by: Janusz Sobczak <janusz.sobczak@imgtec.com>
Signed-off-by: Imre Deak <imre.deak@nokia.com>
---

diff --git a/pvr/hash.c b/pvr/hash.c
index 318d9dd..53593a6 100644
--- a/pvr/hash.c
+++ b/pvr/hash.c
@@ -202,11 +202,9 @@ struct HASH_TABLE *HASH_Create_Extended(u32 uInitialLen, size_t uKeySize,
 	pHash->pfnHashFunc = pfnHashFunc;
 	pHash->pfnKeyComp = pfnKeyComp;
 
-	OSAllocMem(PVRSRV_PAGEABLE_SELECT,
+	if (OSAllocMem(PVRSRV_PAGEABLE_SELECT,
 		   sizeof(struct BUCKET *) * pHash->uSize,
-		   (void **) &pHash->ppBucketTable, NULL);
-
-	if (pHash->ppBucketTable == NULL) {
+		   (void **) &pHash->ppBucketTable, NULL) != PVRSRV_OK) {
 		OSFreeMem(PVRSRV_PAGEABLE_SELECT, sizeof(struct HASH_TABLE),
 			  pHash, NULL);
 		return NULL;