From: J. Bruce Fields <bfields@redhat.com>
Date: Fri, 4 May 2012 18:57:52 +0000 (-0400)
Subject: nfsd4: clarify that renewing expired client is a bug
X-Git-Tag: v3.5-rc1~18^2~5
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7447758be712e891aa4c57f8fa11902ccfdff151;p=pandora-kernel.git

nfsd4: clarify that renewing expired client is a bug

This can't happen:
	- cl_time is zeroed only by unhash_client_locked, which is only
	  ever called under both the state lock and the client lock.
	- every caller of renew_client() should have looked up a
	  (non-expired) client and then called renew_client() all
	  without dropping the state lock.
	- the only other caller of renew_client_locked() is
	  release_session_client(), which first checks under the
	  client_lock that the cl_time is nonzero.

So make it clear that this is a bug, not something we handle.  I can't
quite bring myself to make this a BUG(), though, as there are a lot of
renew_client() callers, and returning here is probably safer than a
BUG().

We'll consider making it a BUG() after some more cleanup.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---

Reading git-diff-tree failed