From: Dave Chinner Date: Fri, 25 Mar 2011 22:14:44 +0000 (+1100) Subject: xfs: xfs_trans_read_buf() should return an error on failure X-Git-Tag: v2.6.39-rc1~15^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7401aafd5019d32a888e5f27332cf580945574bf;p=pandora-kernel.git xfs: xfs_trans_read_buf() should return an error on failure When inside a transaction and we fail to read a buffer, xfs_trans_read_buf returns a null buffer pointer and no error. xfs_do_da_buf() checks the error return, but not the buffer, and as a result this read failure condition causes a panic when it attempts to dereference the non-existant buffer. Make xfs_trans_read_buf() return the same error for this situation regardless of whether it is in a transaction or not. This means every caller does not need to check both the error return and the buffer before proceeding to use the buffer. Signed-off-by: Dave Chinner Reviewed-by: Alex Elder --- Reading git-diff-tree failed