From: Heinrich Schuchardt Date: Tue, 26 Nov 2024 16:19:20 +0000 (-0300) Subject: net: zero terminate string with headers in wget_fill_info() X-Git-Tag: v2025.04-rc1~17^2~80^2~15 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=737c2dca95e5c4fec208026f367a5333fbdad21f;p=pandora-u-boot.git net: zero terminate string with headers in wget_fill_info() Commit 2dd076a9c1b4 ("net: wget: integrate struct wget_info into legacy wget code") introduced function wget_fill_info() which retrieves the headers from the HTTP server response. As we want to parse the string in later patches we need to ensure that it is NUL terminated. We must further check that wget_info->headers in not NULL. Otherwise a crash occurs. Fixes: 2dd076a9c1b4 ("net: wget: integrate struct wget_info into legacy wget code") Signed-off-by: Adriano Cordova Signed-off-by: Heinrich Schuchardt --- diff --git a/net/wget.c b/net/wget.c index 3bc2522cde5..5d70b7a82e0 100644 --- a/net/wget.c +++ b/net/wget.c @@ -208,8 +208,13 @@ static void wget_fill_info(const uchar *pkt, int hlen) const char *second_space; char *pos, *end; - if (wget_info->headers && hlen < MAX_HTTP_HEADERS_SIZE) - strncpy(wget_info->headers, pkt, hlen); + if (wget_info->headers) { + if (hlen < MAX_HTTP_HEADERS_SIZE) + strncpy(wget_info->headers, pkt, hlen); + else + hlen = 0; + wget_info->headers[hlen] = 0; + } //Get status code first_space = strchr(pkt, ' ');