From: Guenter Roeck Date: Wed, 29 Oct 2014 17:44:53 +0000 (-0700) Subject: net: dsa: Don't set skb->protocol on outgoing tagged packets X-Git-Tag: omap-for-v3.19/fixes-rc1~125^2~319^2~14 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=734cbb5b6bf9ee42ab4d71690fabf486b1f44502;p=pandora-kernel.git net: dsa: Don't set skb->protocol on outgoing tagged packets Setting skb->protocol to a private protocol type may result in warning messages such as e1000e 0000:00:19.0 em1: checksum_partial proto=dada! This happens if the L3 protocol is IP or IPv6 and skb->ip_summed is set to CHECKSUM_PARTIAL. Looking through the code, it appears that changing skb->protocol for transmitted packets is not necessary and may actually be harmful. For example, it prevents purposely unmodified (from a DSA perspective) network drivers from properly setting up their transmit checksum offload pointers since they inspect skb->protocol to set up the IPv4 header or IPv6 header pointers. So don't unnecessarily change the protocol field. Signed-off-by: Guenter Roeck Signed-off-by: David S. Miller --- Reading git-diff-tree failed