From: Julia Lawall <julia@diku.dk>
Date: Sat, 6 Feb 2010 08:43:41 +0000 (+0100)
Subject: drivers/dma: Correct NULL test
X-Git-Tag: v2.6.33-rc8~15^2
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=734c2992828c66cee3feb21ecd30a6ac44aecc51;p=pandora-kernel.git

drivers/dma: Correct NULL test

cohd_fin has already been verified not to be NULL, so the argument to
BUG_ON cannot be true.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
expression *x;
expression e;
identifier l;
@@

if (x == NULL || ...) {
    ... when forall
    return ...; }
... when != goto l;
    when != x = e
    when != &x
*x == NULL
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---

Reading git-diff-tree failed