From: Daniel Vetter Date: Wed, 23 Apr 2014 08:24:11 +0000 (+0200) Subject: drm: Handle ->disable_plane failures correctly X-Git-Tag: omap-for-v3.16/fixes-against-rc1~44^2~57^2~9 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=731cce487ab0485c6607e44a0759d92bef1c144e;p=pandora-kernel.git drm: Handle ->disable_plane failures correctly The ->disable_plane hook always had a return value, but only since the introduction of primary planes was there any implementation that actually failed. So handle such failures correctly. Note that drm_plane_force_disable is special: In the modeset cleanup case we first disable all crtc, so primary planes should all be freed already. And in the fb helper we only reset non-primary planes. Still better be paranoid and add an early return. I don't see how this could happen, but it might fix the fb refcount underrun Thierry is seeing. Matt Roper spotted this issue. Cc: Thierry Reding Cc: Ville Syrjälä Cc: Matt Roper Reviewed-by: Matt Roper Signed-off-by: Daniel Vetter --- Reading git-diff-tree failed