From: Shlomo Pongratz <shlomop@mellanox.com>
Date: Sun, 30 Mar 2014 12:26:29 +0000 (+0300)
Subject: scsi/libiscsi: Fix static checker warning on bh locking
X-Git-Tag: omap-for-v3.16/fixes-against-rc1~13^2~112
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=72b9740201d5f0e24b0b8326a4949786a30ff628;p=pandora-kernel.git

scsi/libiscsi: Fix static checker warning on bh locking

Commit 659743b "[SCSI] libiscsi: Reduce locking contention in fast path" introduced a
new smatch warning on libiscsi.c "iscsi_xmit_task() warn: inconsistent returns
bottom_half:: locked (1410 [(-61)]) unlocked (1425 [0], 1425 [s32min-(-1),1-s32max])",
which we can eliminate by using non bh locking on the nested spin_lock call.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Shlomo Pongratz <shlomop@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---

Reading git-diff-tree failed