From: Jack Morgenstein <jackm@dev.mellanox.co.il>
Date: Tue, 17 Feb 2009 22:51:47 +0000 (-0800)
Subject: IPoIB: In unicast_arp_send(), only free newly-created paths
X-Git-Tag: v2.6.30-rc1~665^2^4
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=71d98b4628ee869d62814f6d8607d76cab4b9ec5;p=pandora-kernel.git

IPoIB: In unicast_arp_send(), only free newly-created paths

If path_rec_start() returns error, call path_free() only if the path
was newly-created.  If we free an existing path whose valid flag was zero,
(but do not detach it from the list) we cause corruption of the
path list (of which it is a member), and get a kernel crash.

The simplest solution is to not free an existing path -- just leave it
in the list as-is (i.e., with its valid flag cleared).

Thanks to Yossi Etigin of Voltaire for identifying the problem flow
which caused the kernel crash.

Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Moni Shua <monis@voltaire.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
---

Reading git-diff-tree failed