From: Ilkka Virta Date: Sat, 7 Feb 2009 06:00:36 +0000 (-0800) Subject: sungem: Soft lockup in sungem on Netra AC200 when switching interface up X-Git-Tag: v2.6.29-rc5~42^2~17 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=71822faa3bc0af5dbf5e333a2d085f1ed7cd809f;p=pandora-kernel.git sungem: Soft lockup in sungem on Netra AC200 when switching interface up From: Ilkka Virta In the lockup situation the driver seems to go off in an eternal storm of interrupts right after calling request_irq(). It doesn't actually do anything interesting in the interrupt handler. Since connecting the link afterwards works, something later in initialization must fix this. Looking at gem_do_start() and gem_open(), it seems that the only thing done while opening the device after the request_irq(), is a call to napi_enable(). I don't know what the ordering requirements are for the initialization, but I boldly tried to move the napi_enable() call inside gem_do_start() before the link state is checked and interrupts subsequently enabled, and it seems to work for me. Doesn't even break anything too obvious... Signed-off-by: David S. Miller --- Reading git-diff-tree failed