From: Al Viro Date: Thu, 26 Jul 2007 16:33:29 +0000 (+0100) Subject: ip6_tunnel - endianness annotations X-Git-Tag: v2.6.23-rc2~253 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=704eae1f32274c0435f7f3924077afdb811edd1d;p=pandora-kernel.git ip6_tunnel - endianness annotations Convert rel_info to host-endian before calling ip6_tnl_err(). The things become much more straightforward that way. The key observation (and the reason why that code actually worked) is that after ip6_tnl_err() we either immediately bailed out or had rel_info set to 0 or had it set to host-endian and guaranteed to hit (rel_type == ICMP_DEST_UNREACH && rel_code == ICMP_FRAG_NEEDED) case. So inconsistent endianness didn't really lead to bugs, but it had been subtle and prone to breakage. New variant is saner and obviously safe. Signed-off-by: Al Viro Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed