From: Uwe Kleine-König Date: Thu, 7 Aug 2014 20:17:07 +0000 (+0200) Subject: net: gianfar: fix reference counting for phy_node X-Git-Tag: omap-for-v3.17/fixes-against-rc2~76^2~35 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6f2c9bd85eee30fd77e6c65c097769ad0d6d7352;p=pandora-kernel.git net: gianfar: fix reference counting for phy_node The line before the changed if condition is: priv->phy_node = of_parse_phandle(np, "phy-handle", 0); . If this call succeeds priv->phy_node must not be overwritten in the if block; otherwise the reference to the node returned by of_parse_phandle is lost. So add a check that the if block isn't executed in this case. Furthermore in the fixed phy case no reference is aquired for phy_node resulting in an of_node_put without holding a reference. To fix that, get a reference on the MAC dt node. Fixes: be40364544bd ("gianfar: use the new fixed PHY helpers") Signed-off-by: Uwe Kleine-König Signed-off-by: David S. Miller --- Reading git-diff-tree failed