From: Colin Ian King <colin.king@canonical.com>
Date: Thu, 22 Jan 2015 11:20:40 +0000 (+0000)
Subject: scsi_debug: test always evaluates to false, || should be used instead
X-Git-Tag: fixes-v4.0-rc1~250^2~3
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6d310dfb382a303cbaf838e1b680f55cef18ae03;p=pandora-kernel.git

scsi_debug: test always evaluates to false, || should be used instead

cppcheck found the following issue:
(warning) Logical conjunction always evaluates to false:
  alloc_len < 4 && alloc_len > 65535.

..the test should be instead:

  if (alloc_len < 4 || alloc_len > 65536)

This error was introduced by recent commit 38d5c8336e60bf6e53a1da9
("scsi_debug: add Report supported opcodes+tmfs; Compare and write")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---

Reading git-diff-tree failed