From: David S. Miller <davem@davemloft.net>
Date: Wed, 9 Mar 2011 21:27:16 +0000 (-0800)
Subject: ipv4: Fix erroneous uses of ifa_address.
X-Git-Tag: v2.6.38~22^2~6
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6c91afe1a984d43f922a6a70c7c390b7fb8de45e;p=pandora-kernel.git

ipv4: Fix erroneous uses of ifa_address.

In usual cases ifa_address == ifa_local, but in the case where
SIOCSIFDSTADDR sets the destination address on a point-to-point
link, ifa_address gets set to that destination address.

Therefore we should use ifa_local when we want the local interface
address.

There were two cases where the selection was done incorrectly:

1) When devinet_ioctl() does matching, it checks ifa_address even
   though gifconf correct reported ifa_local to the user

2) IN_DEV_ARP_NOTIFY handling sends a gratuitous ARP using
   ifa_address instead of ifa_local.

Reported-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

Reading git-diff-tree failed