From: Julia Lawall Date: Sun, 29 Dec 2013 22:47:18 +0000 (-0300) Subject: [media] ec168: fix error return code X-Git-Tag: v3.14-rc1~20^2~75 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6c49d79381f4bacacdef50a1902c92833e765c63;p=pandora-kernel.git [media] ec168: fix error return code The rest of the function uses ret to store the return value, even setting ret to i a few lines before this, so return ret instead of i. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // Signed-off-by: Julia Lawall Cc: Antti Palosaari Signed-off-by: Mauro Carvalho Chehab --- Reading git-diff-tree failed