From: H Hartley Sweeten Date: Tue, 11 Sep 2012 17:48:10 +0000 (-0700) Subject: staging: comedi: comedi_fc: introduce cfc_check_trigger_is_unique X-Git-Tag: omap-for-v3.7-rc1/fixes-cpufreq-signed~75^2~359 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6c39eed00cb28d4997ddf3a7aa96a1aff48c8828;p=pandora-kernel.git staging: comedi: comedi_fc: introduce cfc_check_trigger_is_unique "Step 2" of each do_cmdtest checks that the trigger sources are unique by doing something like this for each trigger: if (cmd->start_src != TRIG_TIMER && cmd->start_src != TRIG_FOLLOW && cmd->start_src != TRIG_EXT) err++; /* Test the remaining triggers similarly */ if (err) return 2; Introduce a helper function in comedi_fc to handle this boilerplate. The drivers can then just do: err |= cfc_check_trigger_is_unique(cmd->start_src); /* Test the remaining triggers similarly */ if (err) return 2; Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed