From: Jiri Kosina Date: Thu, 4 Sep 2014 06:56:06 +0000 (+0200) Subject: HID: thingm: fix workqueue race on remove X-Git-Tag: fixes-for-v3.18-merge-window~27^2^8~3 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=67a97845830f79584c9db8849ac723e5d2d57f65;p=pandora-kernel.git HID: thingm: fix workqueue race on remove thingm_remove_rgb() needs to flush the workqueue after all the LED classes have been unregistered, otherwise the removal might race with another LED event coming, causing thingm_led_set() to schedule additional work after thingm_remove_rgb() has flushed it. This obviously causes oops later, as the scheduled work has been freed in the meantime. In addition to that, move the hid_hw_stop() to an earlier place, so that dmesg is not polluted by failure messages about not being able to write the LED while the device is being shut down. Reported-and-tested-by: Dylan Alex Simon Signed-off-by: Jiri Kosina --- Reading git-diff-tree failed