From: Atsushi Nemoto Date: Fri, 19 Feb 2010 05:13:58 +0000 (+0000) Subject: tc35815: Remove a wrong netif_wake_queue() call which triggers BUG_ON X-Git-Tag: v2.6.33~5^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=662a96bd6f020782dfbdc0d0bd177c7dbb556687;p=pandora-kernel.git tc35815: Remove a wrong netif_wake_queue() call which triggers BUG_ON The netif_wake_queue() is called correctly (i.e. only on !txfull condition) from txdone routine. So Unconditional call to the netif_wake_queue() here is wrong. This might cause calling of start_xmit routine on txfull state and trigger BUG_ON. This bug does not happen when NAPI disabled. After txdone there must be at least one free tx slot. But with NAPI, this is not true anymore and the BUG_ON can hits on heavy load. In this driver NAPI was enabled on 2.6.33-rc1 so this is regression from 2.6.32 kernel. Reported-by: Ralf Roesch Signed-off-by: Atsushi Nemoto Signed-off-by: David S. Miller --- Reading git-diff-tree failed