From: Roland Dreier Date: Fri, 25 Jan 2008 22:15:21 +0000 (-0800) Subject: IB/ipath: Fix crash on unload introduced by sysfs changes X-Git-Tag: v2.6.25-rc1~1234^2~80 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=657c2f2cbccbac88689ac5174fc13dd3f9aece34;p=pandora-kernel.git IB/ipath: Fix crash on unload introduced by sysfs changes Commit 23b9c1ab ("Infiniband: make ipath driver use default driver groups.") introduced a bug in the ipath driver where ipath_device_create_group() fell through into the error path, even on success, which meant that the sysfs groups it created would always get removed right away. This made ipath_device_remove_group() hit the BUG_ON() in sysfs_remove_group() when it tried to remove those groups a second time. Correct the return path so that the groups stick around until they are supposed to be cleaned up. Signed-off-by: Roland Dreier --- Reading git-diff-tree failed