From: Takashi Iwai Date: Tue, 16 Apr 2013 10:31:05 +0000 (+0200) Subject: ALSA: hda - Fix aamix activation with loopback control on VIA codecs X-Git-Tag: omap-for-v3.10/dt-fixes-for-merge-window~52^2~40 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=65033cc8d5ffd9b754e04da4be9cd1e8b61eeaff;p=pandora-kernel.git ALSA: hda - Fix aamix activation with loopback control on VIA codecs When we have a loopback mixer control, this should manage the state whether the output paths include the aamix or not. But the current code blindly initializes the output paths with aamix = true, thus the aamix is enabled unless the loopback mixer control is changed. Also, update_aamix_paths() called by the loopback mixer control put callback invokes snd_hda_activate_path() with aamix = true even for disabling the mixing. This leaves the aamix path even though the loopback control is turned off. This patch fixes these issues: - Introduced aamix_default() helper to indicate whether with_aamix is true or false as default - Fix the argument in update_aamix_paths() for disabling loopback Reported-by: Lydia Wang Cc: [v3.9+] Signed-off-by: Takashi Iwai --- Reading git-diff-tree failed