From: Dan Carpenter Date: Tue, 20 Aug 2013 08:57:35 +0000 (+0300) Subject: staging: comedi: dt282x: dt282x_ai_insn_read() always fails X-Git-Tag: v3.2.52~119 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=63a77d815edb770711efc6dc1b2777f49d83d287;p=pandora-kernel.git staging: comedi: dt282x: dt282x_ai_insn_read() always fails commit 2c4283ca7cdcc6605859c836fc536fcd83a4525f upstream. In dt282x_ai_insn_read() we call this macro like: wait_for(!mux_busy(), comedi_error(dev, "timeout\n"); return -ETIME;); Because the if statement doesn't have curly braces it means we always return -ETIME and the function never succeeds. Signed-off-by: Dan Carpenter Acked-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman Signed-off-by: Ben Hutchings --- Reading git-diff-tree failed