From: Julia Lawall Date: Sat, 17 Oct 2009 06:42:49 +0000 (+0200) Subject: ARM: S3C24XX: arch/arm/plat-s3c24xx: Move dereference after NULL test X-Git-Tag: v2.6.32-rc6~6^2~6 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=60e5c1b5ecd99e06d3133a2a20d58d3c2b9968ac;p=pandora-kernel.git ARM: S3C24XX: arch/arm/plat-s3c24xx: Move dereference after NULL test If the NULL test on buf is needed, then the dereference should be after the NULL test. A simplified version of the semantic match that detects this problem is as follows (http://coccinelle.lip6.fr/): // @match exists@ expression x, E; identifier fld; @@ * x->fld ... when != \(x = E\|&x\) * x == NULL // Signed-off-by: Julia Lawall Signed-off-by: Ben Dooks --- Reading git-diff-tree failed