From: Axel Lin Date: Thu, 5 Jul 2012 15:12:49 +0000 (+0800) Subject: regulator: s5m8767: Properly handle gpio_request failure X-Git-Tag: v3.6-rc1~157^2^2~8 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5febb3c9d52c65686a8e473a31f15137852f4b5e;p=pandora-kernel.git regulator: s5m8767: Properly handle gpio_request failure Convert to devm_gpio_request to save a few error handling code. This patch properly handle the gpio_request failure, we should return error when gpio_request fails rather than just show warning. I think one of the reason we got -EBUSY is because current code does not free gpios in s5m8767_pmic_remove(). So it got -EBUSY when reload the module. Yest another reason is in current code if gpio_request() returns error, the rest of the code still calls gpio_direction_output to config buck_gpios and buck_ds gpios. This looks wrong to me. Signed-off-by: Axel Lin Signed-off-by: Mark Brown --- Reading git-diff-tree failed