From: Johannes Berg Date: Mon, 17 Nov 2008 07:20:31 +0000 (-0800) Subject: rtnetlink: propagate error from dev_change_flags in do_setlink() X-Git-Tag: v2.6.28-rc6~62^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5f9021cfdc3524a4c5e3d7ae2d049eb7adcd6776;p=pandora-kernel.git rtnetlink: propagate error from dev_change_flags in do_setlink() Unlike ifconfig, iproute doesn't report an error when setting an interface up fails: (example: put wireless network mac80211 interface into repeater mode with iwconfig but do not set a peer MAC address, it should fail with -ENOLINK) without patch: # ip link set wlan0 up ; echo $? 0 # with patch: # ip link set wlan0 up ; echo $? RTNETLINK answers: Link has been severed 2 # Propagate the return value from dev_change_flags() to fix this. Signed-off-by: Patrick McHardy Tested-by: Johannes Berg Signed-off-by: Johannes Berg Signed-off-by: David S. Miller --- Reading git-diff-tree failed