From: Alexey Khoroshilov Date: Fri, 16 Jan 2015 22:55:26 +0000 (-0300) Subject: [media] cx231xx: fix usbdev leak on failure paths in cx231xx_usb_probe() X-Git-Tag: fixes-v4.0-rc1~147^2~118 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5eeb3014827f44ea7de43c865118cb2095ad030e;p=pandora-kernel.git [media] cx231xx: fix usbdev leak on failure paths in cx231xx_usb_probe() Commit b7085c086475 ("cx231xx: convert from pr_foo to dev_foo") moves usb_get_dev(interface_to_usbdev(interface)) to the beginning of cx231xx_usb_probe() to use udev->dev in dev_err(), but it does not make sure usbdev is put on all failure paths. Later dev_err(udev->dev) was replaced by dev_err(d). So the patch moves usb_get_dev() below (before the first use) and fixes another failure path. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- Reading git-diff-tree failed