From: Nicholas Bellinger Date: Wed, 13 Nov 2013 01:54:56 +0000 (-0800) Subject: iscsi-target: Fix mutex_trylock usage in iscsit_increment_maxcmdsn X-Git-Tag: v3.13-rc1~5^2~16 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5e8e6b4b3adebf01a9d97056cbbfd8c44330df99;p=pandora-kernel.git iscsi-target: Fix mutex_trylock usage in iscsit_increment_maxcmdsn This patch fixes a >= v3.10 regression bug with mutex_trylock() usage within iscsit_increment_maxcmdsn(), that was originally added to allow for a special case where ->cmdsn_mutex was already held from the iscsit_execute_cmd() exception path for ib_isert. When !mutex_trylock() was occuring under contention during normal RX/TX process context codepaths, the bug was manifesting itself as the following protocol error: Received CmdSN: 0x000fcbb7 is greater than MaxCmdSN: 0x000fcbb6, protocol error. Received CmdSN: 0x000fcbb8 is greater than MaxCmdSN: 0x000fcbb6, protocol error. This patch simply avoids the direct ib_isert callback in lio_queue_status() for the special iscsi_execute_cmd() exception cases, that allows the problematic mutex_trylock() usage in iscsit_increment_maxcmdsn() to go away. Reported-by: Moussa Ba Tested-by: Moussa Ba Cc: # v3.10+ Signed-off-by: Nicholas Bellinger --- Reading git-diff-tree failed