From: Oleg Nesterov Date: Tue, 2 Sep 2014 17:57:27 +0000 (+0200) Subject: x86, fpu: copy_process: Sanitize fpu->last_cpu initialization X-Git-Tag: fixes-against-v3.18-rc2~90^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5e23fee23ea10730c752edce1777e6b7e727290f;p=pandora-kernel.git x86, fpu: copy_process: Sanitize fpu->last_cpu initialization Cosmetic, but imho memset(&dst->thread.fpu, 0) is not good simply because it hides the (important) usage of ->has_fpu/etc from grep. Change this code to initialize the members explicitly. And note that ->last_cpu = 0 looks simply wrong, this can confuse fpu_lazy_restore() if per_cpu(fpu_owner_task, 0) has already exited and copy_process() re-allocated the same task_struct. Fortunately this is not actually possible because child->fpu_counter == 0 and thus fpu_lazy_restore() will not be called, but still this is not clean/robust. Signed-off-by: Oleg Nesterov Link: http://lkml.kernel.org/r/20140902175727.GA21666@redhat.com Reviewed-by: Suresh Siddha Signed-off-by: H. Peter Anvin --- Reading git-diff-tree failed