From: Alexey Khoroshilov Date: Sat, 13 Apr 2013 21:52:04 +0000 (-0300) Subject: [media] cx88: Fix unsafe locking in suspend-resume X-Git-Tag: omap-for-v3.10/dt-fixes-for-merge-window~104^2^2~63 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5ddfbbb9ca2e74d4b392ccef675641babba6b7f8;p=pandora-kernel.git [media] cx88: Fix unsafe locking in suspend-resume Legacy PCI suspend-resume handlers are called with interrupts enabled. But cx8800_suspend/cx8800_resume and cx8802_suspend_common/cx8802_resume_common use spin_lock/spin_unlock functions to acquire dev->slock, while the same lock is acquired in the corresponding irq-handlers: cx8800_irq and cx8802_irq. That means a deadlock is possible if an interrupt happens while suspend or resume owns the lock. The patch replaces spin_lock/spin_unlock with spin_lock_irqsave/spin_unlock_irqrestore. Found by Linux Driver Verification project (linuxtesting.org). [mchehab@redhat.com: Fix CodingStyle] Signed-off-by: Alexey Khoroshilov Signed-off-by: Mauro Carvalho Chehab --- Reading git-diff-tree failed