From: Dan Carpenter Date: Mon, 14 Mar 2011 11:06:01 +0000 (-0700) Subject: [SCSI] target: Minor sparse warning fixes and annotations X-Git-Tag: v2.6.39-rc1~52^2~38 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5dd7ed2e811d5cd12f31fb7f0c5ad0107d494a12;p=pandora-kernel.git [SCSI] target: Minor sparse warning fixes and annotations This patch addresses the majority of sparse warnings and adds proper locking annotations. It also fixes the dubious one-bit signed bitfield, for which the signed one-bit types can be 0 or -1 which can cause a problem if someone ever checks if (foo->lu_gp_assoc == 1). The current code is fine because everyone just checks zero vs non-zero. But Sparse complains about it so lets change it. The warnings look like this: include/target/target_core_base.h:228:26: error: dubious one-bit signed bitfield Signed-off-by: Dan Carpenter Signed-off-by: Fubo Chen Signed-off-by: Nicholas A. Bellinger Signed-off-by: James Bottomley --- Reading git-diff-tree failed