From: Julia Lawall Date: Wed, 26 May 2010 05:54:21 +0000 (+0000) Subject: net/rds: Add missing mutex_unlock X-Git-Tag: v2.6.35-rc2~64^2~16 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5daf47bb4e708fde32c1856a0d049e3c3d03c36c;p=pandora-kernel.git net/rds: Add missing mutex_unlock Add a mutex_unlock missing on the error path. In each case, whenever the label out is reached from elsewhere in the function, mutex is not locked. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression E1; @@ * mutex_lock(E1); <+... when != E1 if (...) { ... when != E1 * return ...; } ...+> * mutex_unlock(E1); // Signed-off-by: Julia Lawall Reviewed-by: Zach Brown Acked-by: Andy Grover Signed-off-by: David S. Miller --- Reading git-diff-tree failed