From: Axel Lin Date: Mon, 8 Aug 2011 09:14:19 +0000 (+0800) Subject: platform-drivers-x86: eeepc-laptop: fix wrong test for successful registered led_classdev X-Git-Tag: v3.2-rc1~111^2~26 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5d6afd150321a9e6f1180f5dced9032cce6861ac;p=pandora-kernel.git platform-drivers-x86: eeepc-laptop: fix wrong test for successful registered led_classdev device_create returns &struct device pointer on success, or ERR_PTR() on error. Thus if led_classdev_register fails, led_cdev->dev is always not NULL. If IS_ERR(eeepc->tpd_led.dev) is ture, it means led_classdev_register fails. If (asus->tpd_led.dev) is NULL, it means we call eeepc_led_exit before calling led_classdev_register for &eeepc->tpd_led. We only want to call led_classdev_unregister for sucessfully registered led_classdev, then we should check (!IS_ERR_OR_NULL(eeepc->tpd_led.dev)). Signed-off-by: Axel Lin Acked-by: Corentin Chary Signed-off-by: Matthew Garrett --- Reading git-diff-tree failed