From: Paul Walmsley Date: Thu, 3 Sep 2009 17:13:53 +0000 (+0300) Subject: OMAP: powerdomain: Fix overflow when doing powerdomain deps lookups. X-Git-Tag: v2.6.32-rc1~645^2^2~11 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5d113262ee9e074e0d36362d878892819bfdeb47;p=pandora-kernel.git OMAP: powerdomain: Fix overflow when doing powerdomain deps lookups. At the end of the list pd is a pointer to a NULL struct, so checking if the address == NULL doesn't help here. In fact the original code will just keep running past the struct to read who knows what in memory. This case manifests itself when from clkdms_setup() when enabling auto idle for a clock domain and the clockdomain usecount is greater than 0. When _clkdm_add_autodeps() tries to add the a dependency that does not exist in the powerdomain->wkdep_srcs array the for loop will run past the wkdep_srcs array. Currently in linux-omap you won't hit this because the not found case is never executed, unless you start modifying powerdomains and their wakeup/sleep deps. Signed-off-by: Mike Chan Signed-off-by: Paul Walmsley --- Reading git-diff-tree failed