From: David S. Miller <davem@sunset.davemloft.net>
Date: Fri, 22 Dec 2006 19:42:26 +0000 (-0800)
Subject: [UDP]: Fix reversed logic in udp_get_port().
X-Git-Tag: v2.6.20-rc2~8^2
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5c668704b7fa5a4ebf21a490ddfbd6dc2e01fc97;p=pandora-kernel.git

[UDP]: Fix reversed logic in udp_get_port().

When this code was converted to use sk_for_each() the
logic for the "best hash chain length" code was reversed,
breaking everything.

The original code was of the form:

			size = 0;
			do {
				if (++size >= best_size_so_far)
					goto next;
			} while ((sk = sk->next) != NULL);
			best_size_so_far = size;
			best = result;
		next:;

and this got converted into:

			sk_for_each(sk2, node, head)
				if (++size < best_size_so_far) {
					best_size_so_far = size;
					best = result;
				}

Which does something very very different from the original.

Signed-off-by: David S. Miller <davem@davemloft.net>
---

Reading git-diff-tree failed