From: Michael Reed Date: Fri, 24 Oct 2008 22:13:47 +0000 (-0700) Subject: [SCSI] qla2xxx: Return a FAILED status when abort mailbox-command fails. X-Git-Tag: v2.6.28-rc5~9^2~11 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5bff55db3dc4d659f46b4d2fce2f61c1964c2762;p=pandora-kernel.git [SCSI] qla2xxx: Return a FAILED status when abort mailbox-command fails. Mike Reed noted (https://bugzilla.novell.com/show_bug.cgi?id=421330) that the driver was incorrectly returning a SUCCESS status if the driver's request to the firmware to abort a command failed. By doing so, the mid-layer believed, incorrectly, that the command has completed and has been returned (ultimately clearing scsi_cmnd.request_buffer) yet the driver still has the command. What should correctly happen is a mid-layer escalation (device-reset, etc.) of recovery during which the driver will eventually return the outstanding commands to the mid-layer. Cc: Stable Tree Signed-off-by: Andrew Vasquez Signed-off-by: James Bottomley --- Reading git-diff-tree failed