From: Al Viro Date: Sun, 8 Jan 2012 20:38:27 +0000 (-0500) Subject: functionfs: unfuck failure exits on mount X-Git-Tag: v3.3-rc1~156^2~4 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5b5f9560354dc5a3a27ce57a86aec6b98531ee21;p=pandora-kernel.git functionfs: unfuck failure exits on mount * if you do dput() of root dentry, do *not* follow that with iput() of root inode. * while we are at it, don't do that dput() at all - you are leaving the pointer in ->s_root and your ->kill_sb() will be very unhappy with that. It will do proper dput(), though, so the easiest way is to leave that to it entirely. * freeing ->s_fs_info is also best left to ->kill_sb() (which will do it anyway), especially since we leave the pointer in place. * that xchg() in ->kill_sb() is not a bug per se, but it's a plain and simple masturbation with fewer excuses than Onan had... Signed-off-by: Al Viro --- Reading git-diff-tree failed