From: Stephen Hemminger Date: Sun, 1 Feb 2009 09:40:17 +0000 (-0800) Subject: inet: Fix virt-manager regression due to bind(0) changes. X-Git-Tag: v2.6.30-rc1~662^2~842 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5add300975cf36b1bd30c461105bb938da260f14;p=pandora-kernel.git inet: Fix virt-manager regression due to bind(0) changes. From: Stephen Hemminger Fix regression introduced by a9d8f9110d7e953c2f2b521087a4179677843c2a ("inet: Allowing more than 64k connections and heavily optimize bind(0) time.") Based upon initial patches and feedback from Evegniy Polyakov and Eric Dumazet. From Eric Dumazet: -------------------- Also there might be a problem at line 175 if (sk->sk_reuse && sk->sk_state != TCP_LISTEN && --attempts >= 0) { spin_unlock(&head->lock); goto again; If we entered inet_csk_get_port() with a non null snum, we can "goto again" while it was not expected. -------------------- Signed-off-by: David S. Miller --- Reading git-diff-tree failed