From: Darrick J. Wong Date: Fri, 19 Nov 2010 14:56:44 +0000 (-0500) Subject: ext4: ext4_fill_super shouldn't return 0 on corruption X-Git-Tag: v2.6.37-rc3~1^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5a9ae68a349aa076bc8557ee2fcf865574459282;p=pandora-kernel.git ext4: ext4_fill_super shouldn't return 0 on corruption At the start of ext4_fill_super, ret is set to -EINVAL, and any failure path out of that function returns ret. However, the generic_check_addressable clause sets ret = 0 (if it passes), which means that a subsequent failure (e.g. a group checksum error) returns 0 even though the mount should fail. This causes vfs_kern_mount in turn to think that the mount succeeded, leading to an oops. A simple fix is to avoid using ret for the generic_check_addressable check, which was last changed in commit 30ca22c70e3ef0a96ff84de69cd7e8561b416cb2. Signed-off-by: Darrick J. Wong Signed-off-by: "Theodore Ts'o" --- Reading git-diff-tree failed