From: Nicolas Dichtel Date: Fri, 11 Apr 2014 13:51:18 +0000 (+0200) Subject: gre: don't allow to add the same tunnel twice X-Git-Tag: v3.15-rc1~8^2^2~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5a4552752d8f7f4cef1d98775ece7adb7616fde2;p=pandora-kernel.git gre: don't allow to add the same tunnel twice Before the patch, it was possible to add two times the same tunnel: ip l a gre1 type gre remote 10.16.0.121 local 10.16.0.249 ip l a gre2 type gre remote 10.16.0.121 local 10.16.0.249 It was possible, because ip_tunnel_newlink() calls ip_tunnel_find() with the argument dev->type, which was set only later (when calling ndo_init handler in register_netdevice()). Let's set this type in the setup handler, which is called before newlink handler. Introduced by commit c54419321455 ("GRE: Refactor GRE tunneling code."). CC: Pravin B Shelar Signed-off-by: Nicolas Dichtel Signed-off-by: David S. Miller --- Reading git-diff-tree failed