From: Henrique de Moraes Holschuh Date: Sun, 18 Nov 2007 11:18:29 +0000 (-0200) Subject: ACPI: thinkpad-acpi: fix oops when a module parameter has no value X-Git-Tag: v2.6.24-rc4~107^2~3^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=59f91ff11e594913a5b3c03a4707fdf02338c8df;p=pandora-kernel.git ACPI: thinkpad-acpi: fix oops when a module parameter has no value set_ibm_param() could OOPS with a NULL pointer derreference if one did not give any values for a module parameter it handles. This would, of course, cause all sort of trouble for future modprobing and require a reboot to clean up properly. Fix it by returning -EINVAL if no values are given for the parameter, and also avoid any nastyness from BUG_ON while at it. How to reproduce: modprobe thinkpad-acpi brightness Signed-off-by: Henrique de Moraes Holschuh Tested-by: Mike Kershaw Signed-off-by: Len Brown --- Reading git-diff-tree failed