From: Rasmus Villemoes Date: Tue, 1 Jul 2014 10:25:44 +0000 (+0200) Subject: staging: rtl8821ae: Pass large struct by const reference X-Git-Tag: cleanup-for-v3.18~125^2~1141 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=57fc3b7c4d4dbc368d1b108d63fc9c465204c43a;p=pandora-kernel.git staging: rtl8821ae: Pass large struct by const reference struct rtl_stats is rather huge (152 bytes), and since rtl8812ae_rx_command_packet_handler() does not modify it, it might as well be passed by const reference. Reported by Coverity: CID 1167285 Signed-off-by: Rasmus Villemoes Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8821ae/pci.c b/drivers/staging/rtl8821ae/pci.c index e194ffe58acc..f9847d1fbdeb 100644 --- a/drivers/staging/rtl8821ae/pci.c +++ b/drivers/staging/rtl8821ae/pci.c @@ -861,7 +861,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw) break; } - rtlpriv->cfg->ops->rx_command_packet_handler(hw, status, skb); + rtlpriv->cfg->ops->rx_command_packet_handler(hw, &status, skb); /* *NOTICE This can not be use for mac80211, Reading git-diff-tree failed