From: Ian Abbott Date: Wed, 27 Feb 2013 12:52:46 +0000 (+0000) Subject: staging: comedi: ni_labpc: set up command4 register *after* command3 X-Git-Tag: v3.2.40~26 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=56546c8c2a08d511b6499c7997fd95f22da5400c;p=pandora-kernel.git staging: comedi: ni_labpc: set up command4 register *after* command3 commit 22056e2b46246d97ff0f7c6e21a77b8daa07f02c upstream. Tuomas reported problems getting meaningful output from a Lab-PC+ in differential mode for AI cmds, but AI insn reads gave correct readings. He tracked it down to two problems, one of which is addressed by this patch. It seems that writing to the command3 register after writing to the command4 register in `labpc_ai_cmd()` messes up the differential reference bit setting in the command4 register. Set up the command4 register after the command3 register (as in `labpc_ai_rinsn()`) to avoid the problem. Thanks to Tuomas for suggesting the fix. Signed-off-by: Ian Abbott Signed-off-by: Ben Hutchings --- Reading git-diff-tree failed